loader: Make arm64_image_header public #205
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexOrozco1256
requested review from
sameo,
rbradford,
roypat,
andreitraistaru and
ShadowCurse
as code owners
likebreath
approved these changes
Jul 7, 2025
likebreath
reviewed
Jul 7, 2025
There was a problem hiding this comment.
The CI is complaining about missing docs for public data structure:
error: missing documentation for a struct
--
| --> src/loader/pe/mod.rs:78:1
| \|
| 78 \| pub struct arm64_image_header {
| \| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| \|
| note: the lint level is defined here
| --> src/lib.rs:10:9
| \|
| 10 \| #![deny(missing_docs)]
| \| ^^^^^^^^^^^^
fixed! thanks for the review! |
roypat
reviewed
Jul 8, 2025
This header is equivalent to the boot_params header found at the top of x86 kernels. We want to make this struct public to use it in a fw_cfg implementation that reads the kernel header for both arm and x86 Signed-off-by: Alex Orozco <alexorozco@google.com>
I need to be able to read text_offset to know where the kernel starts. I made all the fields public to mirror the x86 kernel headers. I also updated the riscv struct, thanks for the review! |
roypat
approved these changes
Jul 8, 2025
rbradford
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This header is equivalent to the boot_params header found at the top of x86 kernels. We want to make this struct public to use it in a fw_cfg implementation that reads the kernel header for both arm and x86